Support ScalarizedOutcomeConstraint in _prepare_p_feasible#4856
Closed
mgrange1998 wants to merge 1 commit into
Closed
Support ScalarizedOutcomeConstraint in _prepare_p_feasible#4856mgrange1998 wants to merge 1 commit into
ScalarizedOutcomeConstraint in _prepare_p_feasible#4856mgrange1998 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92185974. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4856 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 591 591
Lines 61874 61909 +35
=======================================
+ Hits 59869 59903 +34
- Misses 2005 2006 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgrange1998
force-pushed
the
export-D92185974
branch
from
c44bcb6 to
e9979bc
Compare
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 9, 2026
…k#4856) Summary: Implementing support for ScalarizedOutcomeConstraint in _prepare_p_feasible and _prepare_p_feasible_per_constraint as specified in the the task T235432214 1. Modified _prepare_p_feasible (lines 621-642): Replaced the old oc_names loop with direct handling that uses _get_scalarized_constraint_mean_and_sem for ScalarizedOutcomeConstraint instances. This removes the TODO comment for T235432214 2. Modified _prepare_p_feasible_per_constraint (lines 706-749): Applied the same pattern to properly compute mean/sigma for scalarized constraints using the helper function. Reviewed By: ItsMrLin Differential Revision: D92185974
…k#4856) Summary: Pull Request resolved: facebook#4856 Implementing support for ScalarizedOutcomeConstraint in _prepare_p_feasible and _prepare_p_feasible_per_constraint as specified in the the task T235432214 1. Modified _prepare_p_feasible (lines 621-642): Replaced the old oc_names loop with direct handling that uses _get_scalarized_constraint_mean_and_sem for ScalarizedOutcomeConstraint instances. This removes the TODO comment for T235432214 2. Modified _prepare_p_feasible_per_constraint (lines 706-749): Applied the same pattern to properly compute mean/sigma for scalarized constraints using the helper function. Reviewed By: ItsMrLin Differential Revision: D92185974
mgrange1998
force-pushed
the
export-D92185974
branch
from
e9979bc to
c170d0e
Compare
|
This pull request has been merged in dc12eec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implementing support for ScalarizedOutcomeConstraint in _prepare_p_feasible and _prepare_p_feasible_per_constraint as specified in the the task T235432214
Modified _prepare_p_feasible (lines 621-642): Replaced the old oc_names loop with direct handling that uses _get_scalarized_constraint_mean_and_sem for ScalarizedOutcomeConstraint instances. This removes the TODO comment for T235432214
Modified _prepare_p_feasible_per_constraint (lines 706-749): Applied the same pattern to properly compute mean/sigma for scalarized constraints using the helper function.
Differential Revision: D92185974