Simplify task value remapping API#4860
Closed
hvarfner wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 5, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 9, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
force-pushed
the
export-D90998243
branch
from
f911e63 to
cd0b2c6
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Feb 9, 2026
Summary: X-link: meta-pytorch/botorch#3163 X-link: meta-pytorch/botorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in facebook#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 9, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 9, 2026
Summary: Pull Request resolved: meta-pytorch#3163 X-link: facebook/Ax#4860 Pull Request resolved: meta-pytorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Feb 9, 2026
Summary: X-link: meta-pytorch/botorch#3163 Pull Request resolved: facebook#4860 X-link: meta-pytorch/botorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in facebook#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
force-pushed
the
export-D90998243
branch
from
cd0b2c6 to
118f984
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 9, 2026
Summary: Pull Request resolved: meta-pytorch#3163 X-link: facebook/Ax#4860 Pull Request resolved: meta-pytorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 593 593
Lines 62291 62284 -7
=======================================
- Hits 60288 60282 -6
+ Misses 2003 2002 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 9, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
force-pushed
the
export-D90998243
branch
from
118f984 to
5d3a960
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Feb 9, 2026
Summary: X-link: meta-pytorch/botorch#3163 X-link: meta-pytorch/botorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in facebook#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 12, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 12, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 12, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message. Differential Revision: D90998243
Summary: X-link: meta-pytorch/botorch#3163 Pull Request resolved: facebook#4860 X-link: meta-pytorch/botorch#3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in facebook#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed. Differential Revision: D90998243
hvarfner
force-pushed
the
export-D90998243
branch
from
5d3a960 to
4451f17
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Feb 13, 2026
Summary: X-link: facebook/Ax#4860 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in meta-pytorch#3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed. Reviewed By: sdaulton Differential Revision: D90998243
meta-codesync Bot
pushed a commit
to meta-pytorch/botorch
that referenced
this pull request
Feb 13, 2026
Summary: Pull Request resolved: #3163 X-link: facebook/Ax#4860 Pull Request resolved: #3146 Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in #3085. The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed. Reviewed By: sdaulton Differential Revision: D90998243 fbshipit-source-id: 04e1b56d082107ccce7594dea19a92ae55da3353
|
This pull request has been merged in d8a75c0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/botorch#3146
Simplifies the get_task_value_remapping() API from 4 parameters to 2, addressing confusion reported in #3085.
The observed_task_values parameter is removed because the parent diff (D90769576) now makes MultiTaskGP track observed/unobserved tasks internally via _observed_task_indices and _unobserved_task_indices. The default_task_value parameter is removed because the previous behavior—silently mapping unknown tasks to an arbitrary fallback—was confusing and error-prone; instead, unrecognized tasks now map to NaN, providing an explicit error sentinel with a clear warning message.
Differential Revision: D90998243