Skip to content

Allow custom tolerated_trial_failure_rate#4954

Closed
sunnyshen321 wants to merge 1 commit into
facebook:mainfrom
sunnyshen321:export-D87092423
Closed

Allow custom tolerated_trial_failure_rate#4954
sunnyshen321 wants to merge 1 commit into
facebook:mainfrom
sunnyshen321:export-D87092423

Conversation

@sunnyshen321
Copy link
Copy Markdown

Summary: Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Differential Revision: D87092423

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 26, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 26, 2026

@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87092423.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 97.40260% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.84%. Comparing base (1054802) to head (9e440e7).

Files with missing lines Patch % Lines
ax/benchmark/benchmark.py 95.00% 1 Missing ⚠️
ax/service/utils/best_point.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4954   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files         601      601           
  Lines       64783    64855   +72     
=======================================
+ Hits        62739    62810   +71     
- Misses       2044     2045    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Feb 26, 2026
Summary:

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 6, 2026
Summary:
Pull Request resolved: facebook#4954

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 11, 2026
Summary:

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 11, 2026
Summary:

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 12, 2026
Summary:

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 12, 2026
Summary:
Pull Request resolved: facebook#4954

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
Summary:
Pull Request resolved: facebook#4954

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
sunnyshen321 pushed a commit to sunnyshen321/Ax that referenced this pull request Mar 12, 2026
Summary:

Allow custom tolerated_trial_failure_rate for failure aware benchmark problems where Standard BO without failure awareness is expected to have a high trial failure rate

Reviewed By: Balandat

Differential Revision: D87092423
@meta-codesync meta-codesync Bot closed this in 2e87ed4 Mar 12, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 12, 2026

This pull request has been merged in 2e87ed4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants