Skip to content

ability to include multiple generator runs in arm effects analysis (#4963)#4963

Closed
bletham wants to merge 2 commits into
facebook:mainfrom
bletham:export-D94707551
Closed

ability to include multiple generator runs in arm effects analysis (#4963)#4963
bletham wants to merge 2 commits into
facebook:mainfrom
bletham:export-D94707551

Conversation

@bletham
Copy link
Copy Markdown
Contributor

@bletham bletham commented Mar 3, 2026

Summary: Pull Request resolved: #4963

Reviewed By: mpolson64

Differential Revision: D94707551

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 3, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 3, 2026

@bletham has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94707551.

bletham added a commit to bletham/Ax that referenced this pull request Mar 3, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
@bletham bletham force-pushed the export-D94707551 branch from 5d7fa6d to 01c79c3 Compare March 3, 2026 17:58
bletham added a commit to bletham/Ax that referenced this pull request Mar 3, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
@bletham bletham force-pushed the export-D94707551 branch from 01c79c3 to d1f4538 Compare March 3, 2026 18:03
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 97.70992% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.29%. Comparing base (0d3535e) to head (2cfa19e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ax/analysis/plotly/arm_effects.py 97.82% 1 Missing ⚠️
ax/analysis/plotly/utils.py 91.66% 1 Missing ⚠️
ax/analysis/utils.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4963      +/-   ##
==========================================
- Coverage   96.29%   96.29%   -0.01%     
==========================================
  Files         611      611              
  Lines       67338    67441     +103     
==========================================
+ Hits        64846    64945      +99     
- Misses       2492     2496       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bletham bletham force-pushed the export-D94707551 branch from d1f4538 to 81518b2 Compare March 9, 2026 16:56
bletham added a commit to bletham/Ax that referenced this pull request Mar 9, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 9, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
@bletham bletham force-pushed the export-D94707551 branch from 81518b2 to b2758fe Compare March 9, 2026 17:00
bletham added a commit to bletham/Ax that referenced this pull request Mar 9, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 10, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Differential Revision: D94707551
@meta-codesync meta-codesync Bot changed the title ability to include multiple generator runs in arm effects analysis ability to include multiple generator runs in arm effects analysis (#4963) Mar 13, 2026
bletham added a commit to bletham/Ax that referenced this pull request Mar 13, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 13, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 13, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 23, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 23, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 23, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 23, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
bletham added a commit to bletham/Ax that referenced this pull request Mar 23, 2026
…acebook#4963)

Summary: Pull Request resolved: facebook#4963

Reviewed By: mpolson64

Differential Revision: D94707551
@meta-codesync meta-codesync Bot closed this in 24cd2ef Mar 23, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Mar 23, 2026

This pull request has been merged in 24cd2ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants