Remove pyre-fixme/pyre-ignore from ax/storage/ source files#4988
Closed
saitcakmak wants to merge 1 commit into
Closed
Remove pyre-fixme/pyre-ignore from ax/storage/ source files#4988saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: Remove ~124 pyre-fixme/pyre-ignore suppression comments from 22 source files in ax/storage/ by applying proper type fixes: - Use `cast(type[SQAClass], ...)` for SQA class lookups from config dicts - Use `cast(type[Enum], enum)` for enum value/name access - Change bare `type` to `type[Any]` in registry function signatures - Use `assert_is_instance()` for JSON dict key narrowing - Add proper type annotations for Generator return types - Use `none_throws()` for generation strategy ID access - Fix SQLAlchemy TypeDecorator parameter types Remaining pyre errors are pre-existing SQLAlchemy/BoTorch stub mismatches that cannot be fixed without changing library type stubs. Differential Revision: D95264795
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95264795. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 599 599
Lines 64584 64594 +10
=======================================
+ Hits 62540 62550 +10
Misses 2044 2044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 6560861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove ~124 pyre-fixme/pyre-ignore suppression comments from 22 source files
in ax/storage/ by applying proper type fixes:
cast(type[SQAClass], ...)for SQA class lookups from config dictscast(type[Enum], enum)for enum value/name accesstypetotype[Any]in registry function signaturesassert_is_instance()for JSON dict key narrowingnone_throws()for generation strategy ID accessRemaining pyre errors are pre-existing SQLAlchemy/BoTorch stub mismatches
that cannot be fixed without changing library type stubs.
Differential Revision: D95264795