Replace em-dash with ASCII in UtilityProgressionPlot subtitle#4997
Closed
saitcakmak wants to merge 1 commit into
Closed
Replace em-dash with ASCII in UtilityProgressionPlot subtitle#4997saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: The UtilityProgressionPlot subtitle for MOO experiments contained a literal em-dash (U+2014), which cannot be encoded in latin-1. When GAIN's daemon scheduler finalizes a multi-objective experiment and saves the analysis card to MySQL, MySQLdb encodes strings using latin-1 and raises UnicodeEncodeError, causing the experiment to be marked as FAILED despite all trials succeeding. Replace the em-dash with " -- " to stay within the latin-1 character set. Reviewed By: bernardbeckerman Differential Revision: D95828166
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95828166. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
==========================================
- Coverage 96.84% 96.84% -0.01%
==========================================
Files 601 601
Lines 64732 64732
==========================================
- Hits 62690 62687 -3
- Misses 2042 2045 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 1054802. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The UtilityProgressionPlot subtitle for MOO experiments contained a literal
em-dash (U+2014), which cannot be encoded in latin-1. When GAIN's daemon
scheduler finalizes a multi-objective experiment and saves the analysis card
to MySQL, MySQLdb encodes strings using latin-1 and raises
UnicodeEncodeError, causing the experiment to be marked as FAILED despite
all trials succeeding.
Replace the em-dash with " -- " to stay within the latin-1 character set.
Reviewed By: bernardbeckerman
Differential Revision: D95828166