Update return type annotation to match botorch API change#5014
Closed
Balandat wants to merge 1 commit into
Closed
Conversation
Summary: Update the return type annotation of `minimal_mixed_optimizer` wrapper function to `tuple[Tensor, Tensor | None]` to match the updated return type of `optimize_acqf_mixed_alternating` from botorch. The upstream botorch function signature changed in D96154880 to return `tuple[Tensor, Tensor | None]` instead of `tuple[Tensor, Tensor]`, which caused the type-checking test to fail. Differential Revision: D96186306
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 601 601
Lines 64783 64783
=======================================
Hits 62739 62739
Misses 2044 2044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 21b9307. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update the return type annotation of
minimal_mixed_optimizerwrapper function totuple[Tensor, Tensor | None]to match the updated return type ofoptimize_acqf_mixed_alternatingfrom botorch.The upstream botorch function signature changed in D96154880 to return
tuple[Tensor, Tensor | None]instead oftuple[Tensor, Tensor], which caused the type-checking test to fail.Differential Revision: D96186306