Remove dead utilities from ax/core/utils.py (#5017)#5017
Closed
lena-kashtelyan wants to merge 1 commit into
Closed
Remove dead utilities from ax/core/utils.py (#5017)#5017lena-kashtelyan wants to merge 1 commit into
lena-kashtelyan wants to merge 1 commit into
Conversation
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96015016. |
meta-cla
Bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5017 +/- ##
==========================================
- Coverage 96.83% 96.83% -0.01%
==========================================
Files 605 605
Lines 65235 65174 -61
==========================================
- Hits 63173 63113 -60
+ Misses 2062 2061 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
Bot
changed the title
lena-kashtelyan
force-pushed
the
export-D96015016
branch
from
5e7400d to
dac2922
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 13, 2026
Summary: Remove dead utilities from `ax/core/utils.py` that have no production callers outside the module itself (only referenced in `test_utils.py`): - `MissingMetrics` (NamedTuple) - `get_missing_metrics` - `get_missing_metrics_by_name` - `_get_missing_arm_trial_pairs` - `best_feasible_objective` Also remove the now-unused imports: `numpy`, `numpy.typing`, `NamedTuple`, `Data`, `MultiObjective`, and `ComparisonOp` from `utils.py`. Reviewed By: saitcakmak Differential Revision: D96015016
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 13, 2026
Summary: Remove dead utilities from `ax/core/utils.py` that have no production callers outside the module itself (only referenced in `test_utils.py`): - `MissingMetrics` (NamedTuple) - `get_missing_metrics` - `get_missing_metrics_by_name` - `_get_missing_arm_trial_pairs` - `best_feasible_objective` Also remove the now-unused imports: `numpy`, `numpy.typing`, `NamedTuple`, `Data`, `MultiObjective`, and `ComparisonOp` from `utils.py`. Reviewed By: saitcakmak Differential Revision: D96015016
lena-kashtelyan
force-pushed
the
export-D96015016
branch
from
dac2922 to
cb5f294
Compare
Summary: Pull Request resolved: facebook#5017 Remove dead utilities from `ax/core/utils.py` that have no production callers outside the module itself (only referenced in `test_utils.py`): - `MissingMetrics` (NamedTuple) - `get_missing_metrics` - `get_missing_metrics_by_name` - `_get_missing_arm_trial_pairs` - `best_feasible_objective` Also remove the now-unused imports: `numpy`, `numpy.typing`, `NamedTuple`, `Data`, `MultiObjective`, and `ComparisonOp` from `utils.py`. Reviewed By: saitcakmak Differential Revision: D96015016
lena-kashtelyan
force-pushed
the
export-D96015016
branch
from
cb5f294 to
e3ad767
Compare
|
This pull request has been merged in f3fd499. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove dead utilities from
ax/core/utils.pythat have no production callersoutside the module itself (only referenced in
test_utils.py):MissingMetrics(NamedTuple)get_missing_metricsget_missing_metrics_by_name_get_missing_arm_trial_pairsbest_feasible_objectiveAlso remove the now-unused imports:
numpy,numpy.typing,NamedTuple,Data,MultiObjective, andComparisonOpfromutils.py.Reviewed By: saitcakmak
Differential Revision: D96015016