Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for GeneratePerfettoConfig() #509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KarlSimonsen
Copy link

Summary:
Add unit tests for GeneratePerfettoConfig().

Covers only some basic cases for now. More can easily be added later as needed.

Please note: this only guards against unintended changes to the config file format, such as has happened a couple of times recently. However, it does NOT guard against everything, including:

  • Flakiness in Perfetto itself (I've seen it work in one run and fail in the next)
  • Flakiness or lack of support on a particular OS version, device, or device type
  • Conflicts with other profilers, such as integrated code putting their own malloc hooks in place

Reviewed By: axitkhurana

Differential Revision: D37396205

Karl Simonsen added 2 commits June 24, 2022 10:06
Summary: Refactor perfetto config file generation to allow unit testing.

Differential Revision: D37301230

fbshipit-source-id: 10a90cc23eec7216ea1720b2bec3afd21fccb788
Summary:
Add unit tests for GeneratePerfettoConfig().

Covers only some basic cases for now. More can easily be added later as needed.

Please note: this only guards against unintended changes to the config file format, such as has happened a couple of times recently. However, it does NOT guard against everything, including:
- Flakiness in Perfetto itself (I've seen it work in one run and fail in the next)
- Flakiness or lack of support on a particular OS version, device, or device type
- Conflicts with other profilers, such as integrated code putting their own malloc hooks in place

Reviewed By: axitkhurana

Differential Revision: D37396205

fbshipit-source-id: 7fbbfc7c4f56396685dfe2a19d003dac0488a0c6
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D37396205

@facebook-github-bot
Copy link

Hi @KarlSimonsen!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants