-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color-Style System Re-Structuring and Colorblind Accessibility #1384
Color-Style System Re-Structuring and Colorblind Accessibility #1384
Commits on Apr 27, 2024
-
feat: Add color scheme selection and colorblind modes to Preferences UI
Add default and example color scheme objects to colors.json. Minify colors.json in build_data.js. Add colors.json to DataLoaderSystem's fileMap. Add color scheme helper functions to StyleSytem, with comments to describe each functions parameters and return values (where applicable). Update StyleSystem's styleMatch() function to interact with color scheme objects from colors.json rather than from STYLE_DECLARATIONS. Fix white space discrepancies in StyleSystem. Update color_selection.js and colorblind_mode_options.js to use StyleSystem rather than the non-existent ColorSystem. Uncomment color schemes and colorblind mode options sections in preferences.js to add them to the Preferences pane of the UI. Refs: Issue facebook#1230
Configuration menu - View commit details
-
Copy full SHA for d588ad2 - Browse repository at this point
Copy the full SHA d588ad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a85cbd - Browse repository at this point
Copy the full SHA 1a85cbdView commit details -
refactor: Enable code to use the created color system
Extract the style definitions to a separate folder, including style definitions which were in colors.json. Add abstracted color and style definitions to minification and data loading files. Load the style definitions alongside color loading in StyleSystem.js. Update style selectors to use newly abstracted style definitions. Map colors defined in the color system to their hex codes. in StyleSystem.js. Reduce the boilerplate code in style matching in StyleSystem.js.
Configuration menu - View commit details
-
Copy full SHA for 4b9a8e2 - Browse repository at this point
Copy the full SHA 4b9a8e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f6814 - Browse repository at this point
Copy the full SHA 51f6814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d2c1d - Browse repository at this point
Copy the full SHA 42d2c1dView commit details -
perf: Add default color scheme handling
Add default color scheme property to StyleSystem.js to hold the default color scheme loaded from color_schemes.json. Abstract out HEX color code determination in styleMatch() into its own function, getHexColorCode. Define getHexColorCode() such that it fetches the HEX color code from the default color scheme if it is not defined in the current color scheme to increase efficiency and reduce the amount of information that has to be defined in a new color scheme object. Optimize color scheme definitions in color_schemes.json to utilize the performance upgrade in getHexColorCode() by removing key-value pairs already in the default color scheme. Add another example colorblind-friendly color scheme. Correct spelling mistake in helper function description.
Configuration menu - View commit details
-
Copy full SHA for 91a22f4 - Browse repository at this point
Copy the full SHA 91a22f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1dde1c - Browse repository at this point
Copy the full SHA f1dde1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee9d116 - Browse repository at this point
Copy the full SHA ee9d116View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1d70b3 - Browse repository at this point
Copy the full SHA c1d70b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cacc04 - Browse repository at this point
Copy the full SHA 1cacc04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0285186 - Browse repository at this point
Copy the full SHA 0285186View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffa9393 - Browse repository at this point
Copy the full SHA ffa9393View commit details -
feat: Hotkey for color scheme switching (ALT + SHIFT + C)
NOTE: Also includes rebasing merge conflict handling
Configuration menu - View commit details
-
Copy full SHA for dd711f7 - Browse repository at this point
Copy the full SHA dd711f7View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 468a851 - Browse repository at this point
Copy the full SHA 468a851View commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee35a89 - Browse repository at this point
Copy the full SHA ee35a89View commit details
Commits on May 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 376336c - Browse repository at this point
Copy the full SHA 376336cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d87956 - Browse repository at this point
Copy the full SHA 6d87956View commit details
Commits on May 14, 2024
-
feat: Make colorblind simulators a poweruser-only feature
Add `showColorblindSimulators` to the array of poweruser features. Add strings for the `showColorblindSimulators` feature in the poweruser pop-up to `core.yaml`. Add `_initHide` property to `section.js` to enable initializing any section `<div>` with a `.hide` class in a non-permanent manner. Call the `initHide()` function with D3.js chaining to set the `_initHide` property of the to `true`, which means that `uiSectionColorblindModeOptions` section should initially be hidden. Add custom on-toggle behavior for `showColorblindSimulators` feature such that the state of the poweruser feature checkbox associated with it adds or removes the `.hide` class from the section's `<div>`.
Configuration menu - View commit details
-
Copy full SHA for dcf234e - Browse repository at this point
Copy the full SHA dcf234eView commit details