Pedestrian Focus Mode #1394
Pedestrian Focus Mode #1394
Conversation
Add default and example color scheme objects to colors.json. Minify colors.json in build_data.js. Add colors.json to DataLoaderSystem's fileMap. Add color scheme helper functions to StyleSytem, with comments to describe each functions parameters and return values (where applicable). Update StyleSystem's styleMatch() function to interact with color scheme objects from colors.json rather than from STYLE_DECLARATIONS. Fix white space discrepancies in StyleSystem. Update color_selection.js and colorblind_mode_options.js to use StyleSystem rather than the non-existent ColorSystem. Uncomment color schemes and colorblind mode options sections in preferences.js to add them to the Preferences pane of the UI. Refs: Issue facebook#1230
|
Hi @salvinax! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I have been doing a lot of work on a very similar topic which is bike infrastructure. I am very happy to chat about what tagging issues we ran into when mapping bike/foot infrastructure on the centerline and as separate geometry. For our mapping campaign https://wiki.openstreetmap.org/wiki/Brandenburg/Kampagne_Radnetz we used iD to help volunteers that don't know a lot about OSM or this kind of mapping to help add data. That is a great learning experience that I am happy to share. A few quick notes
|
|
|
||
| /** | ||
| * styleMatch | ||
| * @param {Object} tags - OSM tags to match to a display style | ||
| * @return {Object} Styling info for the given tags | ||
| */ | ||
| // eslint-disable-next-line complexity |
There was a problem hiding this comment.
Please don't silence the warnings about code complexity.
I think these are useful.
|
This might conflict pretty hard against the work being done on #1384 - are you and @chinweibegbu working together on this? |
Yes, they are! Both features would need some reconciliation/merging once they've collected feedback from us in both these PRs. I asked them to create draft branches to collect feedback via separate draft PRs, but the idea is they'd collapse together after that feedback. |
|
Short video I captured of this feature in action in a busy intersection in amsterdam: Screen.Recording.2024-05-02.at.5.07.21.PM.mov |
The Pedestrian Focus Mode, accessible through the preferences panel, aims to reduce visual clutter and improve the clarity of pedestrian-friendly routes. This pull request builds upon PR #1230, which introduced a color scheme and colorblind mode system.
Changes:
Notes: