Skip to content

Comments

[Misc] Fix Spelling#1780

Merged
Dcallies merged 11 commits intofacebook:mainfrom
b8zhong:2nd-fix-attempt
Mar 11, 2025
Merged

[Misc] Fix Spelling#1780
Dcallies merged 11 commits intofacebook:mainfrom
b8zhong:2nd-fix-attempt

Conversation

@b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Mar 4, 2025

Summary

On target PR so maybe this will work... ? Otherwise I give up

Test Plan

@b8zhong
Copy link
Contributor Author

b8zhong commented Mar 4, 2025

I think it might be a permissions issue on the actions labeller side -- maybe take a look at what rules actions is allowed in this repo?

Weird issue though

@Dcallies
Copy link
Contributor

Dcallies commented Mar 6, 2025

Yeah, I am perplexed, mystified, and confused on this one.

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it working, you can see it triggering on #1789

I tried a few things based on what you did, it was just easier for me because I have merge, and the new labeler doesn't run unless landed as far as I can tell.

@github-actions github-actions bot added python-threatexchange Items related to the threatexchange python tool / library hma Items related to the hasher-matcher-actioner system vpdq Pertaining to the Video PDQ hashing algorithm labels Mar 6, 2025
@b8zhong
Copy link
Contributor Author

b8zhong commented Mar 6, 2025

🙏 Labelling correctly now.. but one is failing?

The configuration file (path: .github/labeler.yml) was found locally, reading from the file
Warning: The action requires write permission to add labels to pull requests. For more information please refer to the action documentation: https://github.com/actions/labeler#permissions
Error: Resource not accessible by integration

Why is this so hard...

@b8zhong b8zhong changed the title [CI] 2nd attempt to fix actions [Misc] Fix Spelling Mar 6, 2025
@b8zhong
Copy link
Contributor Author

b8zhong commented Mar 6, 2025

Feel free to merge or close this one if the typo fixes are worth it lol

@b8zhong b8zhong requested a review from Dcallies March 11, 2025 04:27
Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speels are worth it

@Dcallies Dcallies merged commit 70e89bd into facebook:main Mar 11, 2025
18 of 19 checks passed
@b8zhong b8zhong deleted the 2nd-fix-attempt branch March 11, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed hma Items related to the hasher-matcher-actioner system python-threatexchange Items related to the threatexchange python tool / library vpdq Pertaining to the Video PDQ hashing algorithm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants