[hma] Provide more detailed error when exchange fields are missing #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hma
Contributor
Author
|
The type check error appears unrelated to my changes. |
Dcallies
reviewed
Dec 15, 2025
| abort( | ||
| 400, | ||
| "Failed to parse `api_json` - did you provide all the fields needed for your api cls?", | ||
| f"Failed to parse `api_json` - verify all fields are supplied. {str(e)}", |
Contributor
There was a problem hiding this comment.
You aren't guaranteed that missing key is the reason you got an exception, recommend not including that bit
Suggested change
| f"Failed to parse `api_json` - verify all fields are supplied. {str(e)}", | |
| f"Failed to parse `api_json`: {str(e)}", |
Dcallies
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is very much not intended to be a complete solution, but rather a step towards "better".
Test Plan