Skip to content

chore(ci): upgrade Node 22 -> 24 across all workflows#3045

Merged
zurfyx merged 1 commit into
mainfrom
chore/ci-node-24
Jun 24, 2026
Merged

chore(ci): upgrade Node 22 -> 24 across all workflows#3045
zurfyx merged 1 commit into
mainfrom
chore/ci-node-24

Conversation

@zurfyx

@zurfyx zurfyx commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

Standardizes CI on Node 24 (active LTS), matching facebook/lexical. Bumps node-version: 22 -> 24 in all 9 workflows (17 occurrences): ci, deploy, lint, cli-smoke-test, codemod-verify, vercel-preview, vibe-screenshots, redeploy-preview. No engines/.nvmrc pin exists, so workflows were the only source of truth.

Why

Node 24 bundles npm 11.x, which natively supports OIDC trusted publishing (requires npm ≥ 11.5.1). Node 22 ships npm 10.x — the reason the first OIDC publish returned a misleading 404. This is also why publishing works on Lexical (node 24) and didn't here (node 22).

Independent of #3044 (the explicit npm install -g npm@latest fix), which stays in place as belt-and-suspenders.

Validation ("break nothing")

  • All 13 workflow YAML files parse valid; diff is a pure 17/17 version bump, no other changes.
  • This PR's CI runs the full suite on Node 24 (ci.yml: test/lint/build, plus deploy's test) — the authoritative matrix in the real environment.
  • Additional local smoke in a node:24 linux container (install + test + build) — results in a comment.

Do not merge until all CI checks are green on Node 24.

Standardize CI on Node 24 (active LTS), matching facebook/lexical. Node 24
bundles npm 11.x, which natively supports OIDC trusted publishing (npm >=
11.5.1) — Node 22 shipped npm 10.x, which is why the first OIDC publish 404'd.

Bumps node-version 22 -> 24 in all 9 workflows (17 occurrences): ci, deploy,
lint, cli-smoke-test, codemod-verify, vercel-preview, vibe-screenshots,
redeploy-preview. No engines/.nvmrc pin exists, so workflows are the only
source of truth.

Independent of the #3044 npm-upgrade fix (which stays as belt-and-suspenders).
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 24, 2026
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
astryx Ignored Ignored Jun 24, 2026 5:43pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Vercel Preview Deployment

Status ✅ Deployed
Preview Open Preview
Commit 115b302
Inspect Vercel Dashboard
Workflow View Logs

No authentication required — anyone with the link can view the preview.

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

No new or modified components detected.

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.6KB 0B

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@zurfyx zurfyx merged commit 3f8b3e6 into main Jun 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants