docs(core): document Banner's defaultIsExpanded prop#3208
Merged
cixzhang merged 1 commit intoJun 27, 2026
Conversation
Banner has a public defaultIsExpanded prop (boolean, @default false) that controls whether the collapsible content area starts expanded, but it was missing from the docsite properties tab. Add it (EN + ZH). Found via the interface-vs-doc prop scan.
durvesh1992
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
cixzhang
approved these changes
Jun 27, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Verified defaultIsExpanded matches the source (boolean, default false). Optional, non-blocking: docsDense.propDescriptions is missing a defaultIsExpanded entry, so --dense falls back to the full EN description (other props have a compact one) — worth adding e.g. defaultIsExpanded: 'children start expanded' for consistency. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bannerhas a publicdefaultIsExpandedprop (boolean,@default false) — it controls whether the collapsible content area (children) starts expanded — but it was missing from the docsite properties tab. (The doc even lists "Collapsible content" in its anatomy, but the prop wasn't documented.)Found via the interface-vs-docs prop scan. Added to the EN and ZH doc prop lists.
Testing
defaultIsExpandednow appears in the Banner component registry.Changeset
Included (
@astryxdesign/corepatch, docs).