fix: blockquote example added#3385
Merged
cixzhang merged 1 commit intoJul 3, 2026
Merged
Conversation
mohitWeb-lab
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
@mohitWeb-lab is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Jul 3, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
approved these changes
Jul 3, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Thank you for adding these!
cixzhang
pushed a commit
to AKnassa/astryx
that referenced
this pull request
Jul 4, 2026
…ebook#2759) Every component with a showcase now has at least one example block (type: 'block', no isShowcase) so its docsite page shows viewable, copyable code in the Examples section. Excluded: Blockquote (covered by facebook#3385) and Lightbox (covered by facebook#3301).
cixzhang
added a commit
that referenced
this pull request
Jul 4, 2026
…) (#3481) * docs: add example blocks for 46 components missing viewable code (#2759) Every component with a showcase now has at least one example block (type: 'block', no isShowcase) so its docsite page shows viewable, copyable code in the Examples section. Excluded: Blockquote (covered by #3385) and Lightbox (covered by #3301). * docs: harden 2759 examples after review Use headingHref over deprecated href in TopNavHeading; correct componentsUsed cross-links in 14 block docs; differentiate MobileNavToggle, Resizable, and CommandPaletteFooter examples from their showcases; match TopNavItem preview ratio to its showcase. * docs: address review feedback on 2759 example blocks - ChatDictationButton: wrap the composer in a width-constrained Stack so the example isn't cramped - DropdownMenuItem: drop isMenuOpen/hasAutoFocus/onOpenChange so the menu behaves naturally instead of forcing an open state that scrolls oddly - Resizable: point exampleFor at ResizeHandle (the exported component) - Remove TreeListBranches and TreeListItem example blocks — neither is a real exported component, so the examples were stale - Drop the forced-open isMenuOpen pattern from the DropdownMenu, MoreMenu, and DropdownMenuItem showcases so every menu example renders naturally --------- Co-authored-by: cixzhang <cindyxz@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Blockquote component page had no viewable examples — only a showcase block (hero) with isShowcase: true, which never appears in the Examples section. Visiting the Blockquote docsite page showed an empty
Examples panel with no "Open in playground" link.
Cause
The existing BlockquoteShowcase.doc.mjs registers with exampleFor: 'Blockquote' but also sets isShowcase: true. Showcase blocks are routed to the component hero and excluded from the Examples section, so no
runnable code example was ever surfaced on the page.
Fix
Added two non-showcase example blocks under packages/cli/templates/blocks/components/Blockquote/:
Neither block sets isShowcase, so both land in the Examples section and generate an "Open in playground" link. Re-ran generate-data.mjs to populate exampleRegistry.ts and blockRegistry.ts.
Closes #2759