fix(menu): typeahead in ContextMenu + NavHeadingMenu (menus-11)#3432
Merged
cixzhang merged 1 commit intoJul 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
josephfarina
approved these changes
Jul 2, 2026
cixzhang
requested review from
ejhammond,
imdreamrunner,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
cixzhang
commented
Jul 2, 2026
cixzhang
added a commit
that referenced
this pull request
Jul 2, 2026
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3431 (which adds
useTypeahead+ DropdownMenu). Part of the accessibility & keyboard-management program (#3343). Extendsmenus-11across the menu family.What this adds
Wires the shared
useTypeaheadhook into the remaining menu surfaces:NavHeadingMenu, used by TopNav/SideNav headings) — same, with disabled items skipped.Same integration seam as DropdownMenu: typeahead runs in the menu's
listKeyDownbefore arrow navigation, using each menu'slistRefitems +useListFocus.focusItem. No change to the shared roving hooks.Tests
ContextMenu: typing focuses the matching item. Full ContextMenu + NavMenu + MoreMenu suites green (57 tests), typecheck + lint clean.
Note: must merge after #3431.