refactor(tablist): use shared useListFocus for roving keyboard nav#3451
Merged
Conversation
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
force-pushed
the
navi/refactor/tablist-uselistfocus
branch
from
352408b to
f7e55f8
Compare
josephfarina
approved these changes
Jul 2, 2026
cixzhang
force-pushed
the
navi/refactor/tablist-uselistfocus
branch
from
f7e55f8 to
cb66a6c
Compare
Migrate TabList to the shared useListFocus hook with orientation:'both' instead of its own inline keyboard handler. useListFocus already supports both-axes navigation (Arrow keys + Home/End, disabled-skip, wrap), so the TabList strip becomes a single tab stop driven by the shared hook.
cixzhang
force-pushed
the
navi/refactor/tablist-uselistfocus
branch
from
f6b071f to
513edcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3434 (which merged before this refactor landed). Refactors TabList to use the shared useListFocus hook (adds an opt-in bothAxes option) instead of ad-hoc roving-tabindex logic, per review feedback. Existing TabList tests unchanged. #3343