docs: scrub remaining cosmetic XDS references (example apps, storybook, eslint, tests)#3468
Open
ejhammond wants to merge 1 commit into
Open
docs: scrub remaining cosmetic XDS references (example apps, storybook, eslint, tests)#3468ejhammond wants to merge 1 commit into
ejhammond wants to merge 1 commit into
Conversation
…k, eslint, tests) Cosmetic-only cleanup of leftover XDS brand references, no functional change: - Example apps: XDS -> Astryx in demo page/App headings, prose, <title>s, and layer-order comments across all six example-* apps. - Storybook: picsum placeholder image seeds seed/xds-* -> seed/astryx-*. - eslint.config.js + eslint-plugin-astryx README: renamed local vars xdsPlugin/xdsConfig -> astryxPlugin/astryxConfig and comment headers (the '@AstryX' plugin namespace is unchanged). - Unit tests: fixed stale xds-* references — chat fixtures now use astryx-chat-message/astryx-chat-layout to match the hook's actual selector; arbitrary test ids (astryx-dropdown-menu) and a mismatched fixture package name (@acme/astryx-widgets, aligning name with its directory); stale xds-section comments. Intentional legacy references (codemods, @xds/* compat scope, XDS-prefix detection logic, CHANGELOGs) are left untouched.
ejhammond
requested review from
cixzhang,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cosmetic-only cleanup of leftover
XDSbrand references across example apps, Storybook, the ESLint config, and unit tests. No functional change — every edit is prose, a placeholder string, an internal variable name, or a stale test fixture/comment.This clears the actionable remainder of the
scrub-epic(pre-OSS de-xds). Reconciled against currentmainfirst — three sibling tasks (scrub-file-renames,scrub-sandbox-misc,scrub-pkg-keywords) were already done by prior PRs and have been closed.Changes
example-*):XDS→Astryxin demo page/App headings, prose,<title>s, and CSS layer-order comments.seed/xds-*→seed/astryx-*(arbitrary seeds; different placeholder image, zero behavior impact).eslint.config.js+eslint-plugin-astryx/README.md: renamed local varsxdsPlugin/xdsConfig→astryxPlugin/astryxConfigand comment headers. The'@astryx'plugin namespace key is unchanged.xds-*references —useChatNewMessages.test.tsx: fixtures now useastryx-chat-message/astryx-chat-layoutto match the hook's actualgetElementsByClassName('astryx-chat-message')selector (they were previously mismatched).DropdownMenu.test.tsx: arbitrary test idxds-dropdown-menu→astryx-dropdown-menu.paths.test.mjs: fixture package name@acme/xds-widgets→@acme/astryx-widgets, aligning the name with its own directory (@acme/astryx-widgets).Toolbar/Section: stalexds-sectioncomments that no longer matched the.astryx-sectionassertions.Intentionally left alone
Legacy references that are deliberate and gated
post-v0.1.0: migration codemods, the@xds/*compat scope, theXDS-prefix detection logic (CLI +.github/scripts), theXDS:START/ENDmarker fallback, and CHANGELOGs.Testing
useChatNewMessages,DropdownMenu,Toolbar,Section,paths— 95/95.eslint.config.jsloads correctly with renamed vars (lint runs clean).sync-exports --check,check-sync— pass.