Implement anchored ContextMenu positioning and update documentation#3473
Implement anchored ContextMenu positioning and update documentation#3473akoweicollinxx wants to merge 1 commit into
Conversation
|
@akoweicollinxx is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @akoweicollinxx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This PR updates ContextMenu to use anchored/context positioning instead of fixed cursor coordinates.
The menu is now anchored to the trigger element, which means it:
scroll-follows its target instead of detaching when the page moves
can auto-flip/shift near viewport edges via the anchored layer behavior
preserves the existing focus restoration and Escape-dismiss behavior
What changed
switched ContextMenu from useLayer({ mode: 'fixed' }) to useLayer({ mode: 'context' })
removed fixed x/y positioning from the menu render path
kept right-click open behavior, focus restore, and keyboard navigation intact
Updated ContextMenu docs to describe anchored behavior
Updated tests to match the new anchoring model
Notes
This is a follow-up to the earlier invocation work that intentionally kept fixed positioning. It completes the anchoring follow-up tracked in #3465.
Testing
Updated unit tests for ContextMenu behavior
verified open/close, Escape handling, and focus restoration still pass