Refactor Table theme surface to use semantic themeProps spread#3476
Open
akoweicollinxx wants to merge 1 commit into
Open
Refactor Table theme surface to use semantic themeProps spread#3476akoweicollinxx wants to merge 1 commit into
akoweicollinxx wants to merge 1 commit into
Conversation
|
@akoweicollinxx is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the Table theming surface to match Astryx’s semantic theming conventions.
What changed
Adds semantic Table theme keys:
table
table-row
table-cell
table-header-cell
Preserves existing legacy Table selector aliases so current themes continue to work
Updates Table documentation to show the semantic keys instead of only raw class names
Adds tests to verify both the semantic and legacy theming surfaces resolve correctly
Why
The Table component was the outlier in the theming system: its override targets were exposed as raw class names instead of semantic component keys. This makes Table harder to discover and inconsistent with the rest of the design system.
Compatibility
This is backwards compatible. Existing themes that target the legacy Table selectors should continue to work, while new themes can use the semantic keys.