refactor(core): consolidate inline visually-hidden styles into VisuallyHidden primitive#3491
Draft
cixzhang wants to merge 1 commit into
Draft
refactor(core): consolidate inline visually-hidden styles into VisuallyHidden primitive#3491cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
…lyHidden primitive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
josephfarina
approved these changes
Jul 3, 2026
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates five inline visually-hidden style blocks into the shared
VisuallyHiddenprimitive. Each of these was a screen-reader-only element that is always hidden (loading/status announcements, new-tab context, an always-hidden label), so it maps cleanly onto the primitive with no behavior change.role="status" aria-live="polite")isLabelHiddenusage that mixes withstyles.labelis intentionally left untouched, so its local style block stays)role="status")aria-live="polite")How
<span {...stylex.props(styles.visuallyHidden|srOnly)}>with<VisuallyHidden>, forwarding the samerole/aria-live/idprops (all pass throughBaseProps).Verification
pnpm -F @astryxdesign/core typecheck— pass (exit 0)