docs(dense): restore bestPractices count parity for useListFocus#3494
Open
josephfarina wants to merge 1 commit into
Open
docs(dense): restore bestPractices count parity for useListFocus#3494josephfarina wants to merge 1 commit into
josephfarina wants to merge 1 commit into
Conversation
The docsDense overlay had 3 bestPractices where the English docs have 4; the hasRovingTabIndex/hasCaretGuard guidance bullet was missing, so dense CLI output silently dropped it. Added a compressed version in the same position with the same guidance: true flag, keeping 1:1 parity. Found during Night Watch doc review.
josephfarina
requested review from
cixzhang,
ejhammond,
imdreamrunner,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
useListFocusdocsDenseoverlay listed 3bestPracticeswhere the Englishdocshave 4. The missing bullet was thehasRovingTabIndex/hasCaretGuardguidance (guidance: true), soastryx hook useListFocus --lang densesilently dropped it. The dense translation protocol requires 1:1 count parity with matchingguidanceflags per position.Added a compressed version of the missing bullet in the correct position with
guidance: true. Rendered output now shows all four practices in order.Checklist
pnpm --filter @astryxdesign/core typecheck:docspassesnpx tsc --project packages/cli/tsconfig.template-docs.json --noEmitpassesnode .github/scripts/api-cli-parity-test.mjs --no-baselinepasses (309/309)Night Watch — Doc Reviewer