fix(core): a blank client-hints platform is unknown, not non-Apple

[Astro-Han]

Fixes #5253.

The defect

isApplePlatform() in packages/core/src/hooks/useHotkeys.ts and detectMac() in packages/core/src/Kbd/Kbd.tsx are independent copies of the same detection: prefer navigator.userAgentData.platform, fall back to navigator.platform. The guard on that preference was

if (uaData && typeof uaData === 'object' && 'platform' in uaData) {
  return /mac/i.test((uaData as {platform: string}).platform ?? '');
}
return /Mac|iPhone|iPad|iPod/.test(navigator.platform ?? '');

'platform' in uaData is true whenever the key exists at all, blank or not, and ?? only defends against null/undefined. So a blank platform takes the client-hints branch, evaluates /mac/i.test(''), returns false, and the fallback that would have answered correctly is never reached. An empty string was read as a negative answer rather than as no answer.

Electron and other embedders that rewrite the app's user-agent or client-hints identity ship exactly that. On macOS every mod combo registered through useHotkeys listened for Ctrl instead of Cmd, and every <Kbd> drew Ctrl. Both surfaces agreed with each other, so nothing looked broken: the shortcut simply never fired, and the hint named the key that also did not work. The same code in Safari or Chrome on the same machine behaved correctly.

The fix

A blank (or non-string) platform is treated as unknown and falls through. A client-hints platform that actually names something is still preferred, so nothing changes for browsers that report one.

const uaPlatform = (uaData as {platform?: unknown}).platform;
if (typeof uaPlatform === 'string' && uaPlatform.trim() !== '') {
  return /mac/i.test(uaPlatform);
}

Both call sites change in one commit: the useHotkeys docstring states the hook "Mirrors the detection used by Kbd so displayed and handled shortcuts agree", so fixing one alone would produce the failure this bug is least likely to be noticed in — a shortcut that fires on a key the hint does not name. The shared docstring line is updated in both, kept identical.

Tests

One regression test per call site, written in the platform-spoofing style each file already uses (vi.stubGlobal in useHotkeys.test.ts, Object.defineProperty in Kbd.test.tsx): with userAgentData.platform: '' and navigator.platform: 'MacIntel', mod+k fires on metaKey and not on ctrlKey, and <Kbd keys="mod" /> renders ⌘. Both fail on main and pass with the fix.

Kbd.test.tsx's afterEach also deletes the spoofed userAgentData so nothing leaks into the tests that follow.

Validation

• vitest run on both test files — 31 passed; verified the two new Mac tests fail with the source change reverted
• pnpm -F @astryxdesign/core typecheck, eslint on the touched files, pnpm check:repo — all clean

A [fix] changeset is included (@astryxdesign/core: patch).

---

Diagnosis, patch, and this description were prepared with Claude Code; every line was read and verified by me before opening, and the validation above was run locally.

[meta-cla]

Hi @Astro-Han!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
astryx	Ready	Preview	Aug 22, 2026 7:12am