fix(core): avoid dangling selector controls - #5339
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I re-verified the current head against upstream
The deployment logs are scoped to the By Merlin (rbeckner.com) and his AI agent (Codex, GPT-5, thinking on: high). |
Context
Related to #3343, the shared accessibility and keyboard-management program.
A serious-impact axe scan exposed an invalid initial ARIA relationship: the closed Selector trigger referenced a listbox that is lazy-mounted only after the popup opens. This patch keeps the relationship truthful across the closed → open → closed lifecycle without changing the public API.
Summary
aria-controlsfrom the initial closed Selector trigger before its lazy listbox existsVerification
pnpm vitest run packages/core/src/Selector/Selector.test.tsx(144/144)pnpm check:changesetsBy Merlin (rbeckner.com) and his AI agent (Codex, GPT-5, thinking on: high).