Skip to content

fix(core): avoid dangling selector controls - #5339

Open
light-merlin-dark wants to merge 1 commit into
facebook:mainfrom
light-merlin-dark:codex/selector-controls-mounted-listbox
Open

fix(core): avoid dangling selector controls#5339
light-merlin-dark wants to merge 1 commit into
facebook:mainfrom
light-merlin-dark:codex/selector-controls-mounted-listbox

Conversation

@light-merlin-dark

@light-merlin-dark light-merlin-dark commented Aug 22, 2026

Copy link
Copy Markdown

Context

Related to #3343, the shared accessibility and keyboard-management program.

A serious-impact axe scan exposed an invalid initial ARIA relationship: the closed Selector trigger referenced a listbox that is lazy-mounted only after the popup opens. This patch keeps the relationship truthful across the closed → open → closed lifecycle without changing the public API.

Summary

  • omit aria-controls from the initial closed Selector trigger before its lazy listbox exists
  • restore the relationship whenever the popup is expanded
  • add focused open/close regression coverage and a patch changeset

Verification

  • pnpm vitest run packages/core/src/Selector/Selector.test.tsx (144/144)
  • focused ESLint
  • pnpm check:changesets
  • repository pre-commit checks

By Merlin (rbeckner.com) and his AI agent (Codex, GPT-5, thinking on: high).

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Error Error Aug 22, 2026 4:31pm

Request Review

@meta-cla

meta-cla Bot commented Aug 22, 2026

Copy link
Copy Markdown

Hi @light-merlin-dark!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions Bot added community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge labels Aug 22, 2026
@light-merlin-dark
light-merlin-dark marked this pull request as draft August 22, 2026 16:37
@meta-cla

meta-cla Bot commented Aug 22, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 22, 2026
@light-merlin-dark
light-merlin-dark marked this pull request as ready for review August 22, 2026 18:05
@light-merlin-dark

Copy link
Copy Markdown
Author

I re-verified the current head against upstream main after the Vercel preview reported failure. The code-side release paths are green locally:

  • pnpm build — pass
  • pnpm -F @astryxdesign/docsite build — pass, including TypeScript and all 324 generated routes
  • pnpm vitest run packages/core/src/Selector/Selector.test.tsx — 144/144 pass

The deployment logs are scoped to the fbopensource Vercel account, so I cannot inspect the provider-side failure from the contributor context. Could a maintainer re-run or inspect that preview? No source change appears warranted from the reproducible build evidence.

By Merlin (rbeckner.com) and his AI agent (Codex, GPT-5, thinking on: high).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. community Authored by a community contributor (not on the eng/design team) needs:code-review High-risk change (new package/component/API) — needs human code review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant