fix(AlertDialog): keep actions readable on narrow surfaces - #5343
Open
rubyycheung wants to merge 3 commits into
Open
fix(AlertDialog): keep actions readable on narrow surfaces#5343rubyycheung wants to merge 3 commits into
rubyycheung wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsAlertDialog (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
Summary: - Drive AlertDialog width and action reflow from the <=640px viewport breakpoint instead of touch, pointer, or hover capability. - Add desktop fine-pointer, narrow fine-pointer, and mobile touch coverage and stories. - Update AlertDialog docs and changeset copy. Test Plan: - pnpm exec prettier --write packages/core/src/AlertDialog/AlertDialog.tsx packages/core/src/AlertDialog/AlertDialog.test.tsx apps/storybook/stories/AlertDialog.stories.tsx packages/core/src/AlertDialog/AlertDialog.doc.mjs .changeset/alert-dialog-responsive-actions.md - pnpm exec vitest run packages/core/src/AlertDialog/AlertDialog.test.tsx - pnpm exec eslint packages/core/src/AlertDialog/AlertDialog.tsx packages/core/src/AlertDialog/AlertDialog.test.tsx apps/storybook/stories/AlertDialog.stories.tsx - pnpm exec prettier --check packages/core/src/AlertDialog/AlertDialog.tsx packages/core/src/AlertDialog/AlertDialog.test.tsx apps/storybook/stories/AlertDialog.stories.tsx packages/core/src/AlertDialog/AlertDialog.doc.mjs .changeset/alert-dialog-responsive-actions.md - pnpm -F @astryxdesign/core typecheck - pnpm -F @astryxdesign/storybook typecheck - pnpm -F @astryxdesign/core typecheck:docs - pnpm check:changesets
rubyycheung
marked this pull request as ready for review
August 23, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responsive and Interaction Readiness
Responsive layout
DesktopFinePointer,NarrowFinePointer, andMobileTouchare reference states. Responsive behavior is verified by tests for the wide layout, narrow fine-pointer layout, and mobile-touch layout.Touch, pointer, and hover
Accessibility and interaction contracts
role="alertdialog"andaria-modal.purpose="form", so backdrop/scrim click dismissal is not enabled.Mobile viewport constraints
Test plan
pnpm exec prettier --check packages/core/src/AlertDialog/AlertDialog.tsx packages/core/src/AlertDialog/AlertDialog.test.tsx apps/storybook/stories/AlertDialog.stories.tsx packages/core/src/AlertDialog/AlertDialog.doc.mjs .changeset/alert-dialog-responsive-actions.mdpnpm exec vitest run packages/core/src/AlertDialog/AlertDialog.test.tsxpnpm check:repo