This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Open
Conversation
Lcsmarcal
changed the title
Contributor
|
Sorry for letting this stagnate @Lcsmarcal, do you mind rebasing? The circleci configs got updated to fix these jdk install failures that the circle ci jobs on your PR are failing on. |
Contributor
Author
|
Done @rajyengi. This PR is a work in progress, it can improved with buck developers (or the community itself) code review. Edit: as a WIP, I didn't fix/write the integration tests. I can fix it if you want :) |
Contributor
|
Yeah, I'd be great to have some tests for this new feature. And that |
Contributor
|
@Lcsmarcal is it still WIP? |
|
It would be great to get this merged. Anything I can help make that happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to (#2594)