WIP - Dynamic dependencies for Haskell (discussion)#19
Draft
avdv wants to merge 17 commits into
Draft
Conversation
Similar to D54346421
…` parameter This is going to be useful with new dynamic action rules.
This is used to track libraries that are provided by the haskell toolchain (e.g. by Nix) in the `deps` attribute of Haskell rules.
compiler_flags often needs macro like $(location :target).
- `external_tools`: pass executables called from Haskell compiler during preprocessing or compilation - `srcs_envs`: pass individual run-time env for each source compilation - `use_argsfile_at_link`: use response file at linking
…ependency graph This commit comprises all of the changes needed to use meta data from the Haskell compiler (a JSON file gathered with `ghc -M`) and use that inside of dynamic actions to create module compilation actions, including tracking cross-package dependencies and handling template haskell usage accordingly. This also allows us to put sources into different sub-directories. Co-authored-by: Ian-Woo Kim <ianwookim@gmail.com> Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
facebook-github-bot
added
the
CLA Signed
avdv
changed the title
avdv
pushed a commit
to avdv/buck2-prelude
that referenced
this pull request
Aug 25, 2025
…-catalog Remove toolchain library catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cxx_merge_cpreprocessors_actionsfunction withAnalysisActionsparameteris_haskell_boothelper functionHaskellToolchainLibraryproviderhaskell_toolchain_libraryrulegenerate_target_metadataandghc_wrappertool targetsget_source_prefixeshelper functionghci_lib_pathoptional in template processor scriptIMPORTANT: Please don't raise pull requests here, but at
facebook/buck2.
NOTE: this is a PR to get the discussion started on how to incorporate our changes into upstream.
I'll raise a PR at the buck2 repo soonish.
These changes requires a few GHC patches:
--show-iface-abi-hashhttps://gitlab.haskell.org/ghc/ghc/-/tree/wip/show-iface-abi-hash?ref_type=heads