Skip to content

Conversation

@zsol
Copy link
Contributor

@zsol zsol commented Aug 18, 2025

This PR allows writing:

load(":foo.toml", "value")
print(value)

The toml file is mapped to JSON, and then exposed the same way static JSON files are to starlark code. The single value name in a toml file will always be a dictionary (as TOML files are always tables).

TODO:

  • write e2e tests that are exercised in OSS CI
  • write docs

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D80452768. (Because this pull request was imported automatically, there will not be any future comments.)

@zsol zsol force-pushed the push-zvzmpyupprwk branch from 1eb9fab to 93f4c3c Compare August 18, 2025 16:09
@zsol zsol marked this pull request as ready for review August 18, 2025 16:10
@thoughtpolice
Copy link
Contributor

I've wanted this kind of feature literally a dozen times now, I think, and was recently thinking of (re?)proposing it; thank you so much for it!

@zsol
Copy link
Contributor Author

zsol commented Aug 27, 2025

@JakobDegen wdyt?

@JakobDegen
Copy link
Contributor

Didn't see this

@zsol can you write up an API change proposal that I can copy-paste into Buck2 Dev? Doesn't need to be long, just enough to mention that this is a close analogue to the json case and then if you made any potentially controversial decisions mention those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants