Add configuration option to set the number of event logs retained on disk #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83103192. (Because this pull request was imported automatically, there will not be any future comments.) |
scottcao
requested changes
Sep 29, 2025
| if let Ok(logfiles) = get_files_in_log_dir(logdir) { | ||
| futures::stream::iter(logfiles.into_iter().rev().skip(N_LOGS_RETAINED - 1)) | ||
| futures::stream::iter(logfiles.into_iter().rev().skip(retained_event_logs)) | ||
| .then(|file| async move { |
There was a problem hiding this comment.
Noticed that this went from N -1 to N. Is this correct?
There was a problem hiding this comment.
Maybe having a unit test for this would be helpful to verify that this is actually correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new configuration parameter,
retained_event_logs.The parameter allows users to control the number of event logs retained on disk, replacing the previously hard-coded value of 12.
This change provides greater flexibility for users who need to retain more logs locally when Buck2 logs to disk.