Support for explicit Git object formats in .buckconfig #1110
+83
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional config option for external cells retrieved via Git:
If specified, we pass
--object-format sha1or--object-format sha256as arguments to thegit initinvocation.In both cases we validate that the commit_hash is a valid digest for the respective algorithm. If no object_format is given, we check that the commit_hash is a valid SHA1 digest, but we do not pass the --object-format option when initializing the Git repository.