Skip to content

Conversation

@mmhat
Copy link

@mmhat mmhat commented Sep 29, 2025

This PR adds a new optional config option for external cells retrieved via Git:

[external_cell_foo]
git_origin = ...
commit_hash = ...
object_format = sha1

[external_cell_bar]
git_origin = ...
commit_hash = ...
object_format = sha256

If specified, we pass --object-format sha1 or --object-format sha256 as arguments to the git init invocation.
In both cases we validate that the commit_hash is a valid digest for the respective algorithm. If no object_format is given, we check that the commit_hash is a valid SHA1 digest, but we do not pass the --object-format option when initializing the Git repository.

@meta-cla
Copy link

meta-cla bot commented Sep 29, 2025

Hi @mmhat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2025
@meta-cla
Copy link

meta-cla bot commented Sep 29, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Oct 3, 2025

@Nero5023 has imported this pull request. If you are a Meta employee, you can view this in D83523127. (Because this pull request was imported automatically, there will not be any future comments.)

@Nero5023
Copy link
Contributor

Nero5023 commented Oct 3, 2025

Sorry for late reply. Thank you for doing it!
Could you do a rebase?

@mmhat mmhat force-pushed the external-cells-object-format branch from 14c62b6 to ede39dc Compare October 6, 2025 00:17
@mmhat
Copy link
Author

mmhat commented Oct 6, 2025

Sorry for late reply. Thank you for doing it! Could you do a rebase?

@Nero5023 No problem; I rebased the commit 👍

Summary:
This commit adds a new optional config option for external cells
retrieved via Git:

    [external_cell_foo]
    git_origin = ...
    commit_hash = ...
    object_format = sha1

    [external_cell_bar]
    git_origin = ...
    commit_hash = ...
    object_format = sha256

If specified, we pass `--object-format sha1` or `--object-format sha256`
as arguments to the `git init` invocation.
In both cases we validate that the commit_hash is a valid digest for the
respective algorithm. If no object_format is given, we check that the
commit_hash is a valid SHA1 digest, but we do not pass the
--object-format option when initializing the Git repository.
@mmhat mmhat force-pushed the external-cells-object-format branch from ede39dc to 56c28de Compare October 13, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants