git_fetch: Allow specification of the used object format #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mmhat
force-pushed
the
prelude-object-format
branch
from
b5860d2 to
1d1d054
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83531241. (Because this pull request was imported automatically, there will not be any future comments.) |
mmhat
force-pushed
the
prelude-object-format
branch
from
1d1d054 to
c4bbd0f
Compare
Summary: This commit adds a new (optional) attribute `object_format` to the git_fetch rule. If given, the values of the attribute must be one of `sha1` or `sha256`, and its value is used for the initialization of the underlying Git repository (e.g. `git init --object-format sha1`). The given `rev` is validated according to the chosen object format; If none is provided we still check if the `rev` is a valid SHA1 digest, but we do not pass the --object-format option to Git.
mmhat
force-pushed
the
prelude-object-format
branch
from
c4bbd0f to
070110d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new (optional) attribute
object_formatto the git_fetch rule. If given, the values of the attribute must be one ofsha1orsha256, and its value is used for the initialization of the underlying Git repository (e.g.git init --object-format sha1).The given
revis validated according to the chosen object format; If none is provided we still check if therevis a valid SHA1 digest, but we do not pass the--object-formatoption to Git.