Remove compilation_database.bxl include path hack#1278
Open
cbarrete wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D99027997. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
Author
|
@cjhopman, do you think you could get someone internally to take a look at this? |
Contributor
Author
|
@Nero5023 maybe? |
cbarrete
force-pushed
the
remove-comp-db-hack
branch
from
5f1c4be to
6d06582
Compare
This was a bad hack, which was broken in the presence of header namespaces (in which case `-I .` would not put the actual headers in the include path, causing random jumps to `buck-out` anyway). The correct fix is to use header maps, which integrate correctly with Clang-based tooling, and provide accurate jumping to the source tree. This commit also adds some documentation about this.
cbarrete
force-pushed
the
remove-comp-db-hack
branch
from
6d06582 to
d800201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bad hack, which was broken in the presence of header namespaces (in which case
-I .would not put the actual headers in the include path, causing random jumps tobuck-outanyway).The correct fix is to use header maps, which integrate correctly with Clang-based tooling, and provide accurate jumping to the source tree. This commit also adds some documentation about this.