Skip to content

Skip -ffile-prefix-map for assembler targets#1334

Open
reginaldl wants to merge 2 commits into
facebook:mainfrom
reginaldl:fix/file-prefix-map-nasm
Open

Skip -ffile-prefix-map for assembler targets#1334
reginaldl wants to merge 2 commits into
facebook:mainfrom
reginaldl:fix/file-prefix-map-nasm

Conversation

@reginaldl

Copy link
Copy Markdown
Contributor

Skip -ffile-prefix-map flags for assembler targets (NASM, MASM, gas) which don't understand this compiler option

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2026
@meta-codesync

meta-codesync Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D107446687. (Because this pull request was imported automatically, there will not be any future comments.)

@dtolnay

dtolnay commented Jun 4, 2026

Copy link
Copy Markdown

The _get_category(ext) != "asm_compile" on this line would now always be True:

if compiler_info.compiler_type == "gcc" and _get_category(ext) != "asm_compile":

@reginaldl

Copy link
Copy Markdown
Contributor Author

The _get_category(ext) != "asm_compile" on this line would now always be True:

if compiler_info.compiler_type == "gcc" and _get_category(ext) != "asm_compile":

I updated to check the compiler type instead. Gcc/clang would compile .s/S and support -ffile-map-prefix so my initial condition was too broad.

@dtolnay dtolnay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants