Skip to content

Add -dynamic when linking shared haskell_binary #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbellerb wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

Add -dynamic when linking shared haskell_binary #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/with_prelude/test_utils.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@ def assert_output(name, command, output):
def haskell_library(deps = [], **kwargs):
native.haskell_library(deps = deps + ["//third-party/haskell:base"], **kwargs)

def haskell_binary(linker_flags = [], deps = [], **kwargs):
def haskell_binary(deps = [], **kwargs):
native.haskell_binary(
# Workaround for as yet not triaged runtime segfault.
linker_flags = linker_flags + ["-dynamic"] if host_info().os.is_macos else linker_flags,
deps = deps + ["//third-party/haskell:base"],
**kwargs,
)
2 changes: 1 addition & 1 deletion prelude/haskell/haskell.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ def haskell_binary_impl(ctx: AnalysisContext) -> list[Provider]:
sos_dir = "__{}__shared_libs_symlink_tree".format(ctx.attrs.name)
rpath_ref = get_rpath_origin(get_cxx_toolchain_info(ctx).linker_info.type)
rpath_ldflag = "-Wl,{}/{}".format(rpath_ref, sos_dir)
link.add("-optl", "-Wl,-rpath", "-optl", rpath_ldflag)
link.add("-dynamic", "-optl", "-Wl,-rpath", "-optl", rpath_ldflag)
symlink_dir = create_shlib_symlink_tree(
actions = ctx.actions,
out = sos_dir,
Expand Down