Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prelude: fix zig cxx toolchain (fixes #883) #884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

csarn
Copy link

@csarn csarn commented Mar 20, 2025

I hope it's ok to do two (related) things in one PR, otherwise I can split it up.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@csarn csarn force-pushed the fix-zig-cxx-toolchain branch from ca0d59c to 8efb206 Compare March 20, 2025 21:27
@alexlian alexlian added the prelude Related to integration/prelude label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. prelude Related to integration/prelude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build with cxx_zig_toolchain: Type Error in cxx/zig toolchain definition
3 participants