remote_execution: synchronize concurrent upload of identical artifacts #945
+108
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
|
This is an up-to-date refile of #750 |
ahornby
reviewed
May 7, 2025
| )); | ||
| // Mark artifact as uploaded and notify other potentially waiting tasks. | ||
| if upload_ret.is_ok() { | ||
| prev_uploads.alter(&digest, |_, _| OngoingUploadStatus::Done); |
There was a problem hiding this comment.
does prev_uploads grown unbounded? was expecting to see a removal here to keep it sized to the inflight digests
thoughtpolice
force-pushed
the
aseipp/push-unoqptxykrwl
branch
from
21b8a52 to
7165604
Compare
alexlian
reviewed
May 7, 2025
thoughtpolice
force-pushed
the
aseipp/push-unoqptxykrwl
branch
2 times, most recently
from
bc41b62 to
5b93158
Compare
Currently, upload requests are handled in parallel without knowledge of other ongoing requests. If multiple actions depend on the same set of large locally available artifacts, then they will all be uploaded at the same time. This is particularly poor behavior for large files. Just store in-flight requests in a dashmap, and wait if an upload is already extant. Authored-by: Hugo van der Wijst <[email protected]> Signed-off-by: Hugo van der Wijst <[email protected]> Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-unoqptxykrwl
branch
from
5b93158 to
2b946ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, upload requests are handled in parallel without knowledge of other ongoing requests. If multiple actions depend on the same set of large locally available artifacts, then they will all be uploaded at the same time. This is particularly poor behavior for large files.
Just store in-flight requests in a dashmap, and wait if an upload is already extant.