Flips default use_fbcode_metadata value

[iamricard]

Hi folks 👋🏼 back in #502 there was some discussion on what the default value for use_fbcode_metadata should be. From what I can tell, there was agreement in defaulting it to false but that never happened.

This just flips that flag since OSS users can't leverage the default metadata buck2 sends because fbcode/remote_execution/grpc/metadata.proto is not open source (or at least does not live in this repo), and the config option is undocumented so it's hard for users to track down why metadata might be missing.

[facebook-github-bot]

Hi @iamricard!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[thoughtpolice]

Wow, so the false change slipped by completely? Good fix! I think this should definitely go in, but I wonder if we might need to #[cfg] it? /cc @alexlian

[iamricard]

Wow, so the false change slipped by completely? Good fix! I think this should definitely go in, but I wonder if we might need to #[cfg] it? /cc @alexlian

No problem!

To quote your own comment, @thoughtpolice 😬:

We could #[cfg] that choice, but I'm sure Meta can override it with a simple -c buck2_re_client.use_fbcode_metadata=true flag to buck2 in their test harness.

I understood that as no so that's why I went with the simplest change I could.