build: include dotslash files and improve error messages #956
+218
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it much easier to test buck2-with-buck2 builds. Signed-off-by: Austin Seipp <[email protected]>
If you don't generate a proper BUCK file with `reindeer` then the build fails rather mysteriously. Instead we can use a trick to force a bad error: an ordinary BUCK file that will always fail(), and have reindeer instead generate a BUCK.v2 file which will then be loaded first and take priority. Signed-off-by: Austin Seipp <[email protected]>
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
lf-
reviewed
May 9, 2025
|
Yeah, if upstream is OK with this (I have no idea why the lint is failing) then I'm happy to update the documentation on bootstrapping the build, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it way easier to test buck2-with-buck2 bootstrap builds. It also tries to fix #948