buck2_external_cells_bundled: fix self-referential prelude target usage #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
8 times, most recently
from
94b5507 to
2a0dbc6
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
4 times, most recently
from
8ff43e5 to
e129015
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
5 times, most recently
from
0682691 to
ccee96b
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
2 times, most recently
from
0a91c74 to
2e07382
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
2e07382 to
510f5c7
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
510f5c7 to
69b784d
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
69b784d to
9485c1d
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
2 times, most recently
from
f79490d to
b12d585
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
b12d585 to
0d1f9cf
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
0d1f9cf to
343cd3a
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
343cd3a to
7540067
Compare
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
7540067 to
63c1df9
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D75575062. (Because this pull request was imported automatically, there will not be any future comments.) |
This is a subtle but where using `prelude//:source_listing` means that a buck2-on-buck2 build will produce an invalid binary, because `prelude//` refers to the prelude *inside the source binary*. Introduce a new cell and refer to it with that. Closes facebook#971. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-yzurmxmzovlk
branch
from
63c1df9 to
c511ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtle but where using
prelude//:source_listingmeans that a buck2-on-buck2 build will produce an invalid binary, becauseprelude//refers to the prelude inside the source binary. Introduce a new cell and refer to it with that.Closes #971.