2024-04-01

cells: Repro broken cell handling in file watcher

Summary: Explanation in the diff. This seems pretty bad, I'm not going to fix it though, because it's kind of hard.

Reviewed By: stepancheg

Differential Revision: D55573384

fbshipit-source-id: b7b4483fcf34179bdeb18e33713ab7ce9422e857

2024-03-15

buck2: glossary: snake casing nit

Summary: ^

Reviewed By: JakobDegen

Differential Revision: D54929757

fbshipit-source-id: 12bc297b977c82062bdce9d5c41c6ff5b6b6a870

2024-03-01

Pass correct rpath origin setting to linker on Darwin for Haskell (#567)

Summary:
This is a follow-up to https://github.com/facebook/buck2/issues/536 which fixes a problem on Darwin when trying to execute a haskell_binary fails with:

```
dyld[13654]: Library not loaded: rpath/lib_backend.dylib
  Referenced from: <no uuid> /Users/runner/work/buck-out/v2/gen/root/6e975d09ae66fe71/backend/one-off-task/__one-off-task__/one-off-task
  Reason: tried: '$ORIGIN/__one-off-task__shared_libs_symlink_tree/lib_backend.dylib' (no such file), '$ORIGIN/__one-off-task__shared_libs_symlink_tree/lib_backend.dylib' (no such file), '/usr/local/lib/lib_backend.dylib' (no such file), '/usr/lib/lib_backend.dylib' (no such file, not in dyld cache)
```

Pull Request resolved: https://github.com/facebook/buck2/pull/567

Reviewed By: simonmar

Differential Revision: D54346421

Pulled By: JakobDegen

fbshipit-source-id: 00d5d9fd44fb52b24f80bfecdf0cf3683b1e44b1

2024-02-15

Support GODEBUG env-var

Summary: Support setting [GODEBUG](https://go.dev/doc/godebug) on toolchain level

Reviewed By: leoleovich

Differential Revision: D53769175

fbshipit-source-id: 5a685f74ff9ad44a22f7fe2271a232697836132f

2024-02-01

Fix union return type in buck2 cfg

Summary: https://fburl.com/workplace/o4ae6dwy

Reviewed By: apolloww

Differential Revision: D53290572

fbshipit-source-id: 53bdd7017842edfc911074e49fa310f07cbad56b

2024-01-15

rules: Reimplement native unbundled deps to better support `FORCE_RLI…

2024-01-02

Back out "Move e2e under meta_only"

Summary:
Original commit changeset: 2e0ffb40ab38

Original Phabricator Diff: D52293327

This is making lots of buck2 tests flaky/broken
https://fburl.com/omh/6dqojh2j

Reviewed By: zertosh

Differential Revision: D52397329

fbshipit-source-id: 823ab22b059008f27862bdfcef2bcabe87b3c128

2023-12-15

support dsymutil_extra_flags

Summary: ditto

Reviewed By: chatura-atapattu

Differential Revision: D51426025

fbshipit-source-id: 842816a72ed0a79e4b2c1bccd5ae6f66e3b3b0cd

2023-12-01

Add time_to_first_test_discovery

Summary: This timing information gives an insight of how long it takes to finish building the first test binary when 'buck2 test' is executed. It captures the first test discovery time because it occurs earlier than all the test execution.

Reviewed By: iguridi

Differential Revision: D51673956

fbshipit-source-id: 82ee4c9da2a5971ab805768b0af5595367a1228b

2023-11-15

Make AnalysisQueryResult struct

Summary: For code navigation. Clear now where `AnalysisQueryResult` is created for example.

Reviewed By: JakobDegen

Differential Revision: D51315032

fbshipit-source-id: 14cf33550ba56d5541a1be154cd2d6dca0106780