latest

clean: Don't parallelize symlink deletions

Summary:
We have some CI jobs on which buck2 clean is taking 30min. Heavy lock contention in btrfs with very parallel cleans is why: https://fburl.com/strobelight/t9wk0nb6

 1. Avoid parallel deletions of symlinks, deleting symlinks looks a lot more like deleting empty directories than deleting files
 2. Use std's `remove_dir_all` over doing the unlinks by hand. It holds dirfds open and does other stuff that's a lot smarter than the naive loop that we had

Reviewed By: krallin

Differential Revision: D85305909

fbshipit-source-id: 1742ebc5a6a7f2d01bdf93b2d21646f2ce764249

2025-10-15

Add tags and cli args to CommandStart

Summary: Want to add tags to know if memory-tracker-enabled is set for lost builds. CLI args just nice to have, mostly for the UI, but is easy to add at the same time.

Reviewed By: JakobDegen

Differential Revision: D84556257

fbshipit-source-id: 55a5959097da7b6516c905066d98942f58914e5a

2025-10-01

Apply race/asan flags when filter source files

Summary: Bug repot: https://fb.workplace.com/groups/codegophers/permalink/29592458917042675/

Reviewed By: RollerMatic

Differential Revision: D83609821

fbshipit-source-id: 9c11ea46ae1722ef1aafc439fe0d922fa1d42dd8

2025-09-15

Linkers: correctly pass flags for $(ldflags-shared)

Summary: Apple platforms required a set of linker flags to be always present, so ensure `$(ldflags-shared)` macro that can be used in `cxx_genrule()` contains them.

Reviewed By: rmaz

Differential Revision: D82305068

fbshipit-source-id: d74067717971935fde6ace39edb3bd1f052e5686

2025-09-01

prelude/go: "tansition" typo fix (#1091)

Summary: Pull Request resolved: https://github.com/facebook/buck2/pull/1091

Reviewed By: JakobDegen

Differential Revision: D81271184

fbshipit-source-id: a06cbda4b17bfc787a132d0229752e9aedefa95a

2025-08-15

Allow clippy::uninlined_format_args

Summary:
This lint is failing buck2-oss jobs on revisions that used to pass, I can repro it with codesync but not directly in the repo, despite the fact that codesync does not modify any relevant code.

It's unclear to me how a lint could be flaky, presumably it's not the lint itself, but in any case this doesn't seem useful and it's disabled elsewhere in the repo.

Reviewed By: Will-MingLun-Li

Differential Revision: D80303763

fbshipit-source-id: 23f8b83422bacd8efca2953839ab827c5114ae4e

2025-08-01

Make KIC default

Summary:
### Context
We are integrating the Kotlin Incremental Compiler (KSIC) into Buck to enable incremental compilation of Kotlin source files. This aims to enhance build speed by recompiling only modified source files within a target, rather than rebuilding the entire target.

### This diff
After testing on IG and WA, KIC will be the default option for all Kotlin targets.

*Note: This change will be announced by a public post before landing.*

Reviewed By: IanChilds

Differential Revision: D79264690

fbshipit-source-id: 44d4b0fd7db301ff80f96f08109873e6e1acf433

2025-07-15

file watcher: Make a watchman test more flexible

Summary: Test is flakey. Idk what's going on in watchman

Reviewed By: scottcao

Differential Revision: D78302620

fbshipit-source-id: 6db777df93c8097257606137830209f6263ffc29

2025-07-01

Don't save inputs if we're never going to use them

Summary: If we're never going to run dep-files (because there are no dep-files declared), then we do not need to create `shared_declared_inputs`, since we'll never use them anyway.

Reviewed By: scottcao

Differential Revision: D75438242

fbshipit-source-id: b0667628a6145fbba194e2c81f98c70dee4058ef

2025-06-15

Fix up broken buck2_explain test

Summary:
Slightly ironic that buck2 explain test case started failing right after iguridi left.

The issue seems to be that BUCK_WRAPPER_UUID was not set for the first build command which launched the daemon, so env var was not propagated properly. Not sure why it was working before. Maybe someone was trying this locally and it caused the corresponding log to be populated in manifold and the TTL only expired recently.

Reviewed By: JakobDegen

Differential Revision: D76648150

fbshipit-source-id: ca556341358bbb1714e7e13db40e4fb1a2814086