fix(theme): mobile drawer sidebar should use native modal dialog and backdrop #10706
+54
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the deploy preview of this PR
|
hidde
force-pushed
the
fix/use-native-modal-dialog
branch
3 times, most recently
from
b175464 to
36c07aa
Compare
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
hidde
force-pushed
the
fix/use-native-modal-dialog
branch
from
36c07aa to
dd443d9
Compare
|
@slorber : |
7 tasks
hidde
force-pushed
the
fix/use-native-modal-dialog
branch
from
dd443d9 to
0e38363
Compare
This uses the `<dialog>` element with `showModal()` method, so that we can leverage the browser's built-in ways to make this dialog modal, including keyboard handling (Esc), backdrop and focus trap. Fixes the issue that it was possible to tab outside the dialog while it was open. This removes the backdrop component, as the `<dialog>` element comes with a backdrop built-in, that is styled via CSS instead.
hidde
force-pushed
the
fix/use-native-modal-dialog
branch
from
0e38363 to
dbee3b0
Compare
slorber
changed the title
slorber
changed the title
slorber
changed the title
slorber
added
the
Argos
slorber
requested changes
Feb 27, 2025
There was a problem hiding this comment.
I'd be happy to use <dialog>
But the current implementation doesn't really work like before 😅
We need to preserve:
- the styling
- the drawer animated transition
- the drawer closing on backdrop click
FYI I upgraded your branch to resolve conflicts without changing the behavior you implemented
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
<dialog>element withshowModal()method, so that we can leverage the browser's built-in ways to make this dialog modal, including keyboard handling (Esc), backdrop and focus trap.Fixes the issue that it was possible to tab outside the dialog while it was open.
Rmoves the backdrop component, as the
<dialog>element comes with a backdrop built-in, that is styled via CSS instead.fixes #9457
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-10706--docusaurus-2.netlify.app/
Related issues/PRs