Provide toString() in image objects created by lqip-loader#10891
Closed
tats-u wants to merge 1 commit intofacebook:mainfrom
Closed
Provide toString() in image objects created by lqip-loader#10891tats-u wants to merge 1 commit intofacebook:mainfrom
toString() in image objects created by lqip-loader#10891tats-u wants to merge 1 commit intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
requested changes
Feb 3, 2025
Collaborator
slorber
left a comment
There was a problem hiding this comment.
I didn't have time to investigate the linked issue yet, but this isn't the way I want to address this problem.
The loader could be disabled when the file is requested in a CSS file. We already do that for the SVGR plugin using issuer, because transforming SVGs to React component code doesn't make sense when using CSS such as url('/icon.svg'). This problem is quite similar.
Contributor
Author
|
I see. Looks like it's less useful than I thought in lqip-loader. |
Contributor
Author
|
Note: still useful in responsive-loader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.Motivation
Image objects created by lqip-loader don't provide their own
toString(). It causes the[object Object]output when they are loaded via CSS (#10862).Test Plan
Test links
Deploy preview: https://deploy-preview-10891--docusaurus-2.netlify.app
Related issues/PRs
#10862