docs: Suggest remark-cjk-friendly in migration guide#10892
Merged
slorber merged 1 commit intofacebook:mainfrom Feb 3, 2025
Merged
docs: Suggest remark-cjk-friendly in migration guide#10892slorber merged 1 commit intofacebook:mainfrom
remark-cjk-friendly in migration guide#10892slorber merged 1 commit intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
remark-cjk-friendly in migration guideremark-cjk-friendly in migration guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.Motivation
It requires a lot of effort to ensure to replace all
*and**not recognized as emphasis markers by CommonMark/MDXv2+ with<em>and<strong>in large CJK documents. I think they cannot be found by a simple regex. It is much easier to depend onremark-cjk-friendlyremark plugin for CJK documents.Test Plan
Check the changed page and confirm it looks great
Test links
Deploy preview: https://deploy-preview-10892--docusaurus-2.netlify.app/docs/migration/v3/#emphasis-starting-or-ending-with-a-space-or-a-punctuation
Related issues/PRs
*and**in Chinese and Japanese in MDX v2+ #9692