Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-debug): upgrade react-json-view-lite to v2.3.0 for react 19 #10903

Merged

Conversation

reece-white
Copy link
Contributor

@reece-white reece-white commented Feb 5, 2025

React 19 was added as a peer dependency for react-json-view-lite in https://github.com/AnyRoad/react-json-view-lite/releases/tag/2.2.0, so updating this lib to better support react 19.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

CI & Preview

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 70993b8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67a34ff59d71b1000847b62c
😎 Deploy Preview https://deploy-preview-10903--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 5, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 42 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 50 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 59 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 6, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't harm, but not strictly needed since we already used a ^ semver range

@slorber slorber merged commit 0162f6a into facebook:main Feb 6, 2025
40 checks passed
@Zamiell
Copy link
Contributor

Zamiell commented Feb 23, 2025

not strictly needed since we already used a ^ semver range

Just to clarify, I think it is needed, since installing a fresh Docusaurus website with React 19 currently results in the following ugly npm output:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   27 more (@docsearch/react, @docusaurus/core, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.13.1 || ^17.0.0 || ^18.0.0" from [email protected]
npm warn node_modules/@docusaurus/plugin-debug/node_modules/react-json-view-lite
npm warn   react-json-view-lite@"^1.2.0" from @docusaurus/[email protected]
npm warn   node_modules/@docusaurus/plugin-debug
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/react
npm warn   peer react@"^16.13.1 || ^17.0.0 || ^18.0.0" from [email protected]
npm warn   node_modules/@docusaurus/plugin-debug/node_modules/react-json-view-lite
npm warn     react-json-view-lite@"^1.2.0" from @docusaurus/[email protected]
npm warn     node_modules/@docusaurus/plugin-debug

Now that this pull request is merged, I guess I would expect this warning to go away after the next release / version bump, whenever that will be.

@slorber
Copy link
Collaborator

slorber commented Feb 24, 2025

This is the output of v3.7, still using ^1

This PR was not strictly needed since I already upgraded to ^2 in a PR #10819

IE, with/without this PR, this warning wouldn't appear when initializing a v3.8 site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants