-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugin-debug): upgrade react-json-view-lite to v2.3.0 for react 19 #10903
chore(plugin-debug): upgrade react-json-view-lite to v2.3.0 for react 19 #10903
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't harm, but not strictly needed since we already used a ^ semver range
Just to clarify, I think it is needed, since installing a fresh Docusaurus website with React 19 currently results in the following ugly npm output:
Now that this pull request is merged, I guess I would expect this warning to go away after the next release / version bump, whenever that will be. |
This is the output of v3.7, still using ^1 This PR was not strictly needed since I already upgraded to ^2 in a PR #10819 IE, with/without this PR, this warning wouldn't appear when initializing a v3.8 site |
React 19 was added as a peer dependency for
react-json-view-lite
in https://github.com/AnyRoad/react-json-view-lite/releases/tag/2.2.0, so updating this lib to better support react 19.Pre-flight checklist
Motivation
Test Plan
CI & Preview
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs