Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-type-aliases): pin react-helmet-async to @slorber/[email protected] #10998

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

cylewaitforit
Copy link
Contributor

@cylewaitforit cylewaitforit commented Mar 15, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes warning when installing dependencies.

Yarn warns:

warning Pattern ["react-helmet-async@npm:@slorber/react-helmet-async@*"] is trying to unpack in the same destination "/home/.cache/yarn/v6/npm-react-helmet-async-1.3.0-11fbc6094605cf60aa04a28c17e0aab894b4ecff-integrity/node_modules/react-helmet-async" as pattern ["react-helmet-async@npm:@slorber/[email protected]"]. This could result in non-deterministic behavior, skipping.

Test Plan

Check that there is no warning during yarn install https://app.netlify.com/sites/docusaurus-2/deploys/67d56f144b21080008ab6517#L149

Test links

Deploy preview: https://deploy-preview-10998--docusaurus-2.netlify.app/

Related issues/PRs

#10997

@facebook-github-bot
Copy link
Contributor

Hi @cylewaitforit!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Mar 15, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 621d5d2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67d56f144b21080008ab6517
😎 Deploy Preview https://deploy-preview-10998--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Report too large to display inline

View full report↗︎

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 15, 2025
@cylewaitforit cylewaitforit marked this pull request as ready for review March 15, 2025 12:24
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 17, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@slorber slorber merged commit b0b95cc into facebook:main Mar 17, 2025
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

["react-helmet-async@npm:@slorber/react-helmet-async@*"] is trying to unpack in the same destination
3 participants