refactor(ideal-image-plugin): internalize legacy component code #11010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: -279 B (0%) Total Size: 11.3 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -348 B (0%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
…comp' into slorber/internalize-ideal-image-comp
|
Report too large to display inline |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This moves the code of our unmaintained npm dependency fork to our monorepo: https://github.com/slorber/docusaurus-react-ideal-image
The goal is to reduce friction in maintaining that code, and clean it up and take ownership of it incrementally
See also need to maintain it here: #11000
Note: this PR doesn't change the component behavior, it only moves the existing code more or less as-is. We want to make it easy to see the history of changes so refactors will happen in other PRs later.
Test Plan
unit tests + preview + argos
I keep package unit tests too, but commented a few tests that were complicated to keep working.
Test links
https://deploy-preview-11010--docusaurus-2.netlify.app/
Pages with ideal images: