docs(i18n): fix cp commands causing duplicate files in some shells #11687
Conversation
The i18n tutorial and git workflow docs used `cp -r dir/**` which causes duplicate files in shells like Fish where the glob expands before the -r flag processes recursively. Fix by: - Using `cp -r dir/.` for recursive directory copies - Removing -r and using single `*` for file pattern copies Fixes facebook#11158 Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Hi @poetryofcode! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
El dom., 25 de enero de 2026 10:32 p. m., Poetry Of Code <
***@***.***> escribió:
… *poetryofcode* left a comment (facebook/docusaurus#11687)
<#11687 (comment)>
CLA is signed.
—
Reply to this email directly, view it on GitHub
<#11687 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWTJKI7FXCDE6QS43KKUVBL4IWKHJAVCNFSM6AAAAACS3E3KG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJXHA3DANBRHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
El lun., 26 de enero de 2026 12:13 a. m., meta-cla[bot] <
***@***.***> escribió:
… *meta-cla[bot]* left a comment (facebook/docusaurus#11687)
<#11687 (comment)>
Thank you for signing our Contributor License Agreement. We can now accept
your code for this (and any) Meta Open Source project. Thanks!
—
Reply to this email directly, view it on GitHub
<#11687 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWTJKI5AXPP4GIKWVLJDA3T4IWV7BAVCNFSM6AAAAACS3E3KG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJYGAZTCMRTGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
website/docs/i18n/i18n-tutorial.mdx
Outdated
| cp -r src/pages/**.md i18n/fr/docusaurus-plugin-content-pages | ||
| cp -r src/pages/**.mdx i18n/fr/docusaurus-plugin-content-pages | ||
| cp src/pages/*.md i18n/fr/docusaurus-plugin-content-pages | ||
| cp src/pages/*.mdx i18n/fr/docusaurus-plugin-content-pages |
There was a problem hiding this comment.
We want to copy pages in subfolders as well
website/docs/i18n/i18n-git.mdx
Outdated
| cp src/pages/*.md i18n/fr/docusaurus-plugin-content-pages | ||
| cp src/pages/*.mdx i18n/fr/docusaurus-plugin-content-pages |
There was a problem hiding this comment.
We want to copy pages in subfolders as well
Use `cp -r src/pages/. dest` instead of separate glob commands, matching the pattern already used for docs and blog copies. Co-Authored-By: Claude Opus 4.5 <[email protected]>
3 participants
Pre-flight checklist
UTING.md#pull-requests.
dogfooding pages to fully verify the new behavior.
issue (closes cp commands in i18n tutorial create duplicate file (recursing AND globbing) #11158) and the maintainers have approved on my working
plan.
Motivation
The i18n tutorial documentation contains shell commands that use both -r
(recursive) and ** (glob pattern) together, which causes duplicate files
to be created in certain shells like Fish. When the glob pattern **
expands before the -r flag processes, files get copied multiple times.
This was reported in issue #11158.
Test Plan
This is a documentation-only change. The fix can be verified by:
observe duplicate files
behavior with no duplicates
The new commands are standard POSIX-compliant and work consistently across
bash, zsh, and fish shells.
Test links
https://deploy-preview-_____--docusaurus-2.netlify.app/docs/i18n/tutorial
https://deploy-preview-_____--docusaurus-2.netlify.app/docs/i18n/git
Related issues/PRs