fix(theme-classic): restore color emoji presentation for DocCard category fallback#11990
Open
markselby9 wants to merge 1 commit intofacebook:mainfrom
Open
fix(theme-classic): restore color emoji presentation for DocCard category fallback#11990markselby9 wants to merge 1 commit intofacebook:mainfrom
markselby9 wants to merge 1 commit intofacebook:mainfrom
Conversation
…gory fallback The category fallback emoji literal `'🗃'` (U+1F5C3 CARD FILE BOX) was introduced in facebook#11734 without a U+FE0F variation selector. On platforms whose default presentation for this codepoint is text (notably Windows 11 and many Linux distributions), the glyph renders monochrome instead of the intended color emoji. Append U+FE0F to force emoji presentation, matching the convention already used by the sibling `'📄️'` literal on the next line. Closes facebook#11962
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores color emoji presentation for the DocCard category icon fallback. PR #11734 (v3.10) rewrote the literal as
'🗃'(just U+1F5C3 — Unicode default presentation is text), so on Win11 and many Linux setups it renders monochrome. The sibling'📄️'literal two lines below already includes U+FE0F — this PR matches that convention.One-character fix: append U+FE0F to the literal at
packages/docusaurus-theme-classic/src/theme/DocCard/index.tsx:30.Test plan
prettier --checkclean[0x1f5c3, 0xfe0f]after fix (matches sibling[0x1f4c4, 0xfe0f])'🔗'U+1F517) checked — hasEmoji_Presentation=True, doesn't need the fixFixes #11962